Allow setting a cubemap as default parameter to shader #95126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
shader_cubemap_fix
branch
3 times, most recently
from
acde2bb to
e2457ad
Compare
Chaosus
force-pushed
the
shader_cubemap_fix
branch
from
e2457ad to
d2d8081
Compare
Bromeon
reviewed
Aug 4, 2024
Chaosus
force-pushed
the
shader_cubemap_fix
branch
3 times, most recently
from
ac1a70e to
6262260
Compare
Calinou
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
Testing project: test_cubemap_shader.zip
Chaosus
force-pushed
the
shader_cubemap_fix
branch
3 times, most recently
from
56b40e1 to
5b2f8ed
Compare
Chaosus
force-pushed
the
shader_cubemap_fix
branch
from
5b2f8ed to
acbfb4c
Compare
Chaosus
force-pushed
the
shader_cubemap_fix
branch
from
acbfb4c to
db251a3
Compare
AThousandShips
approved these changes
Aug 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow to correctly setup a Cubemap node in visual shader (using both Cubemap and CompressedCubemap resources).
Before:
After:
