Assign return value on Variant operator failure
#95166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:core
cherrypick:4.2
akien-mga
approved these changes
Sep 19, 2024
aaronp64
force-pushed
the
variant_op_err_return
branch
from
4e741eb to
d22865f
Compare
Variant operators for String formatting and "in" could result in errors, which would return from validated_evaluate without assigning r_ret. This would cause scripts using the return value from these operators to get results from previously run code. Updated to return the original String value in the String formatting case, and false for "in" when an error occurs.
aaronp64
force-pushed
the
variant_op_err_return
branch
from
d22865f to
714357e
Compare
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variantoperators forStringformatting andincould result in errors, which would return fromvalidated_evaluatewithout assigningr_ret. This would cause scripts using the return value from these operators to get results from previously run code. Updated to return the originalStringvalue in theStringformatting case, and false forinwhen an error occurs.Fixes #95152