Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of property_can_revert() in various classes #95175

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 5, 2024

Similar to #88665

@KoBeWi KoBeWi added this to the 4.4 milestone Aug 5, 2024
@KoBeWi KoBeWi changed the title Fix implementation of property_can_revert() in EditorSettings Fix implementation of property_can_revert() in EditorSettings Aug 5, 2024
@KoBeWi KoBeWi requested review from a team as code owners August 22, 2024 20:37
@KoBeWi
Copy link
Member Author

KoBeWi commented Aug 22, 2024

I noticed the same problem in some other classes.

@KoBeWi KoBeWi changed the title Fix implementation of property_can_revert() in EditorSettings Fix implementation of property_can_revert() in various classes Aug 22, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, then should be fine to merge.

@KoBeWi KoBeWi requested a review from a team as a code owner October 4, 2024 21:02
@Repiteo Repiteo merged commit 9d5a732 into godotengine:master Oct 10, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 10, 2024

Thanks!

@KoBeWi KoBeWi deleted the bruh_can_revert branch October 11, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants