Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkbox alignment when using compact theme spacing #95193

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix checkbox alignment when using compact theme spacing #95193

merged 1 commit into from
Aug 16, 2024

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Aug 6, 2024

Believe this should fix #88696

Before:
image

After:
image

@Giganzo Giganzo requested review from a team as code owners August 6, 2024 10:34
@akien-mga akien-mga added this to the 4.4 milestone Aug 6, 2024
Calinou
Calinou approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Example at 200% editor scale:

image

Spacious at 100% editor scale still looks good in terms of CheckBox spacing:

image

@akien-mga akien-mga merged commit 01c0b39 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Giganzo Giganzo deleted the fix-checkbox-alignment-compact-mode branch August 20, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Godot UI Compact Mode - Checkbox not aligned with Rest of UI
3 participants
@Giganzo @akien-mga @Calinou