Fix AudioStreamPlayer get_playback_position() for web build

[yahkr]

fixes #95128

get_playback_position was missing a js hookup with audio samples updates

[adamscott]

This fix is interesting. But it takes for granted that the browser will play the sample without a hitch. Technically, I think that we should rather implement something like mentioned here: WebAudio/web-audio-api#2397 (comment)

With that solution, we get a more precise position of the playhead, not just an approximation.

[yahkr]

This fix is interesting. But it takes for granted that the browser will play the sample without a hitch. Technically, I think that we should rather implement something like mentioned here: WebAudio/web-audio-api#2397 (comment)

With that solution, we get a more precise position of the playhead, not just an approximation.

Definitely looks like a tricky implementation with how godot-processor works, wondering if this approximation is a good fix for the moment

will keep digging into this

[yahkr]

@adamscott Gave it a shot... basically constructing a new AudioWorklet for each SampleNode to keep track of its playback by parsing the incoming buffer length.

process(inputs, _outputs, _parameters) {
		if (inputs.length > 0) {
			const input = inputs[0];
			if (input.length > 0) {
				this.position += input[0].length;
				this.port.postMessage({ 'cmd': 'position', 'data': this.position });
				return true;
			}
		}
		return true;
	}

[adamscott]

Great work! Didn't test it yet, I'm doing this right now.
If it works well, I'll try to push the fix for 4.3.

There's only a few renames and nitpicks, but globally, it's a great implementation. Thanks!

[yahkr]

oh im dumb, i forgot why i moved to manual, audio cant autoplay on web until you click into the page. so thats why i didnt hear yours half the time. but we would still need the this.start() in the setup as it used to be called upon SampleNode creation when you call .play()

Give this latest push a try, autoplay / manual appear working.

edit: it appears i curse myself anytime i say its working. manual playing isnt in latest....
edit2: nvm, I just tried to play an audio past the end of the mp3. all is well :)

updated_mrp.zip

[adamscott]

Last changes that I can see.

[yahkr]

Last changes that I can see.

The errors do need separate names. But thank you for the reviews! Made changes :)

[adamscott]

Works for me! Thank you, @yahkr, for your time and effort. Very appreciated.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 4.3.1.