[RegEx] Add show_error parameter to control error printing on compilation fail
#95212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Aug 6, 2024
Calinou
reviewed
Aug 6, 2024
Calinou
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Tested locally on https://github.com/godotengine/godot-demo-projects/tree/master/gui/regex (by editing the compile() call to have false as a second parameter), it works as expected.
AThousandShips
changed the title
show_error parameter to control error printing on compilation failshow_error parameter to control error printing on compilation fail
Germenzi
force-pushed
the
regex-show-error
branch
6 times, most recently
from
81dc8fa to
89cb76f
Compare
AThousandShips
approved these changes
Aug 7, 2024
Germenzi
force-pushed
the
regex-show-error
branch
from
89cb76f to
022ff69
Compare
akien-mga
reviewed
Aug 27, 2024
Germenzi
force-pushed
the
regex-show-error
branch
from
022ff69 to
f648de1
Compare
|
Omg why it closed. I tried to rebase my brach to new version, and I done it successfully, but PR was closed automatically. Can it be reopened? I'm sorry for my follies, my exp in git ends up in |
akien-mga
approved these changes
Aug 28, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements godotengine/godot-proposals#10381