Add method for getting packet flags from ENetPacketPeer #95216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
approved these changes
Sep 29, 2024
|
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
Chaosed0
force-pushed
the
enet-get-packet-flags
branch
from
9d837a3 to
d36fa76
Compare
|
Thanks for the heads up. I've rebased all the commits onto the latest |
|
It seems good, yes! The final step for our PR workflow would be to squash the commits together. See this page for instructions. I can also do it myself before merging tomorrow. |
akien-mga
force-pushed
the
enet-get-packet-flags
branch
from
d36fa76 to
21c5a73
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes proposal 10240: godotengine/godot-proposals#10240
This PR adds the
get_packet_flagsmethod toENetPacketPeerwhich can be used to obtain the flags sent with the packet. In my experimentation, it appears that not all flags are replicated from peer to peer, but it's unclear which are and which aren't (the ENet documentation does not specify), so I opted not to include this info explicitly in Godot's documentation.This is my first PR, so let me know if I have missed anything.
Bugsquad edit: