Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize project name when importing project #95245

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 7, 2024

Fresh new hack to fix #95234
When importing project, the project dialog's validation still checks the project name, even though the field is hidden. This ensures that name is non-empty when importing.

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes the bug.

I really don't understand how this code works though, how does resetting a String remove a "Create dialog" checkbox... that really seems brittle 😅

@akien-mga akien-mga merged commit 33fe10c into godotengine:master Aug 7, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the regression_flood branch August 7, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import existing project isn't working properly
2 participants