Fix snapping when zoomed in Polygon2D UV editor
#95259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.3
KoBeWi
reviewed
Aug 20, 2024
KoBeWi
approved these changes
Aug 20, 2024
kleonc
force-pushed
the
polygon2d_uv_editor_fix_zoomed_snapping
branch
from
e9be686 to
1b7626f
Compare
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading the code I concluded that
uv_draw_ofsis not affected by theuv_draw_zoom, hence should be multpliplied by it as well when snapping.Also simplified some code when reading.
Fixes #94385.
(v4.3.rc2.official [3978628])
(this PR)