Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid function declaration with a const qualifier in shaders #95274

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Forbid function declaration with a const qualifier in shaders #95274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions servers/rendering/shader_language.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9640,6 +9640,11 @@ Error ShaderLanguage::_parse_shader(const HashMap<StringName, FunctionInfo> &p_f
break;
}

if (is_constant) {
_set_error(vformat(RTR("'%s' qualifier cannot be used with a function return type."), "const"));
return ERR_PARSE_ERROR;
}

FunctionInfo builtins;
if (p_functions.has(name)) {
builtins = p_functions[name];
Expand Down
Loading