-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copy-paste and cut-paste in GridMap #95322
Conversation
is it too late to get into 4.3? knowing it is a small, uncontroversial fix with big usability improvement? |
We are only merging critical regressions right now, it'll hopefully make it into 4.3.1 |
that would be great, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
Note that I still find the copy/paste UX in the GridMap editor to be suboptimal (I'd expect to be able to press Ctrl + V to confirm copying or cutting and be able to do it multiple times), but this will do for now.
Thanks! |
Thank you for merging my contribution!
I am using it and I think it works pretty well, but I agree that these are not really copy/paste and cut/paste functions. The current behaviours could probably be better named as "Duplicate Selection" (already the case*) and "Move Selection"; and their shorcuts could be a one key shorcut. Furthermore, I would probably change the option "Paste Selects" to something clearer like "Keep Original selected", and group the "Move Selection", "Duplicate Selection", "Keep Original Selected" together is the menu. But, what I would really like to work on next, is to surface all this tools in a bottom panel and show them as icons, see this proposal: |
Cherry-picked for 4.3.1. |
fix #52608 which also makes "paste selects" option useful again.
The idea of the fix is to block the propagation of the click once the Gridmap has consumed it.