Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix polygon drawing for transposed tiles in TileSet editor #95337

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Fix polygon drawing for transposed tiles in TileSet editor #95337

merged 2 commits into from
Aug 16, 2024

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Aug 9, 2024

Fixes #73517, both issues mentioned in there:

(used 2D platformer demo from 4.1 branch for testing)

  • Drawing within TileAtlasView indicators for tile shape / texture origin. Checking whether they're in bounds was broken for odd size tile (glorious rect's integer half-size + checking points at the bottom/right edges) / transposed alternative tiles.
Before
(v4.3.rc3.official [03afb92])		 After
(this PR)
Godot_v4 3-rc3_win64_LO3WOdw3l9 Godot_v4 3-rc3_win64_eDDUeveAF8 godot windows editor dev x86_64_Gk7kZ7vpB0
Godot_v4 3-rc3_win64_FqF50lNjgK OIMNZnSa0x fX79kvAyHx
  • Drawing in GenericTilePolygonEditor when editing a transposed alternative tile.
Before
(v4.3.rc3.official [03afb92])		 After
(this PR)
9p81eDEHq4
Godot_v4 3-rc3_win64_BqmwxxXuri		 godot windows editor dev x86_64_jZ9sXXvIuR
godot windows editor dev x86_64_YJkKMG0JJ5
Godot_v4 3-rc3_win64_PxseEZiY6A
RuMezYNbr7		 godot windows editor dev x86_64_EYvHYXhAtt
xFHswSbDpj

2D editor and runtime look all the same before/after.

1bi8eJalAB 49eySUdfer

@kleonc kleonc added this to the 4.4 milestone Aug 9, 2024
@kleonc kleonc requested review from KoBeWi and groud August 9, 2024 17:31
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 12, 2024
@akien-mga akien-mga merged commit 60b0b5c into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the tile_set_editor_fix_transposed_polygons_editing branch August 16, 2024 16:22
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud

@KoBeWi KoBeWi

Assignees
No one assigned
Labels
bug topic:editor topic:2d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

TileSet Alternative transposed tile incorrectly offsets collision shape (and representative tile orange box)
3 participants
@kleonc @akien-mga @groud