Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation on TreeItem's cell icons. #95369

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Improve documentation on TreeItem's cell icons. #95369

merged 1 commit into from
Sep 8, 2024

Conversation

apples
Copy link
Contributor

@apples apples commented Aug 10, 2024

TreeItem's documentation is a bit lacking when it comes to icons. This PR documents some behavior that I had to learn experimentally.

@apples apples requested a review from a team as a code owner August 10, 2024 22:21
@Calinou Calinou added enhancement documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 11, 2024
@Calinou Calinou added this to the 4.4 milestone Aug 11, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Aug 11, 2024

I believe the side chosen for the icon is dependent on the layout (RTL or LTR), so it's not always right.

@apples
Copy link
Contributor Author

apples commented Aug 12, 2024

I believe the side chosen for the icon is dependent on the layout (RTL or LTR), so it's not always right.

Ah, yes, you'd be correct. Would "begin"/"end" be better phrasing, then?

@apples apples force-pushed the treeitem-docs-icon-improvements branch from 1877620 to 2c78284 Compare September 7, 2024 00:38
Mickeon
Mickeon approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, you'd be correct. Would "begin"/"end" be better phrasing, then?

Sorry for not answering sooner. In my opinion, yes. It could be more explicit and mention the LTR layout, but it would be harder to read with the way the descriptions are currently.

@akien-mga akien-mga merged commit f995dc1 into godotengine:master Sep 8, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@jss2a98aj jss2a98aj mentioned this pull request Nov 14, 2024
Merged
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@apples @Mickeon @akien-mga @Calinou