Expose AudioStreamPlayer{2D,3D}::set_playing and remove AudioStreamPlayer::{2D,3D}::_is_active
#95375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
force-pushed
the
gdextension/expose-property-accessors/AudioStreamPlayer
branch
3 times, most recently
from
8b40c50 to
3b4d17f
Compare
…mPlayer::{2D,3D}::_is_active`
- The `_is_active` method seems to be unused, so it was removed.
- The `_set_playing` method is now exposed, as the setter of the `playing` property.
- The `play` method can't be used as a setter because it takes a `float` parameter instead of a `bool` parameter.
raulsntos
force-pushed
the
gdextension/expose-property-accessors/AudioStreamPlayer
branch
from
3b4d17f to
7fd261c
Compare
|
Thanks! |
raulsntos
deleted the
gdextension/expose-property-accessors/AudioStreamPlayer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_is_activemethod seems to be unused, so it was removed._set_playingmethod is now exposed, as the setter of theplayingproperty.playmethod can't be used as a setter because it takes afloatparameter instead of aboolparameter.Alternative
Make the
playingproperty read-only, so it has no setter andset_playingis not exposed. Users can use the already exposedplay/stopmethods instead. This would break compatibility in C#, and it's not technically doing the same thing as_set_playingdoes although I'm not familiar enough with the code to know if the differences here matter.