Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stop_callable to AudioStreamPlayerInternal #95386

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add stop_callable to AudioStreamPlayerInternal #95386

merged 1 commit into from
Aug 16, 2024

Conversation

kus04e4ek
Copy link
Contributor

@kus04e4ek kus04e4ek requested review from a team as code owners August 11, 2024 12:34
@AThousandShips AThousandShips added bug topic:audio regression cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 11, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Aug 11, 2024
@akien-mga akien-mga requested a review from KoBeWi August 11, 2024 20:55
@akien-mga akien-mga merged commit e526882 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@kus04e4ek kus04e4ek deleted the close-audio branch August 19, 2024 06:09
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug regression topic:audio
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Setting playing to true and then to false on the same frame results in playing still being true
4 participants
@kus04e4ek @akien-mga @KoBeWi @AThousandShips