Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Only include profiling variables when DEBUG is enabled #95408

Merged
merged 1 commit into from
Aug 16, 2024
Merged

GDScript: Only include profiling variables when DEBUG is enabled #95408

merged 1 commit into from
Aug 16, 2024

Conversation

alesliehughes
Copy link
Contributor

Since these are only used in debug builds, added the relevant ifdefine around them. Also initial a variable that wasn't missed.

@alesliehughes alesliehughes requested a review from a team as a code owner August 12, 2024 00:22
@dalexeev dalexeev added this to the 4.4 milestone Aug 12, 2024
akien-mga
akien-mga approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, I didn't find other accesses to these outside DEBUG_ENABLED.

@akien-mga akien-mga changed the title gdscript: Only include profiling variables when DEBUG is enabled GDScript: Only include profiling variables when DEBUG is enabled Aug 12, 2024
@akien-mga akien-mga merged commit cc894e5 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:gdscript
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alesliehughes @akien-mga @dalexeev