Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cleanup code on DisplayServer init failure to prevent crash on exit. #95513

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 14, 2024

DisplayServer/RenderingDriver failure, Main::setup2() was returning without cleaning up stuff it already initialized and without calling Main::setup() cleanup code, causing crash on exit.

@bruvzg bruvzg added this to the 4.4 milestone Aug 14, 2024
@bruvzg bruvzg requested a review from a team as a code owner August 14, 2024 08:41
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 16, 2024
@akien-mga akien-mga merged commit a88b828 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants