Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect warning on SkeletonModifier #95548

Merged

Conversation

TokageItLab
Copy link
Member

As noted in comment #95537 (comment), SkeletonModifier has a different internal mechanism than BoneAttachment, so it will never have an external Skeleton.

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@TokageItLab TokageItLab added bug topic:editor topic:3d cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 15, 2024
@TokageItLab TokageItLab added this to the 4.4 milestone Aug 15, 2024
@TokageItLab TokageItLab requested review from a team August 15, 2024 07:55
@TokageItLab TokageItLab requested a review from a team as a code owner August 15, 2024 07:55
@akien-mga akien-mga merged commit a6c3507 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect warning; SkeletonModifier3D has no option to set external skeleton
4 participants