Allow picking partial properties in PropertySelector #95554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
subproperty_of_a_subproperty_of_a_property
branch
from
d81d743 to
f42055f
Compare
kleonc
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
PropertySelector allows picking properties of an Object, but I sometimes missed being able to pick a sub-property, e.g.
position:x. They had to be specified manually, which is rather cumbersome.
Indeed that's currently cumbersome. Moreover, I've seen plently of users being not even aware that you can reference subproperties like that. So this PR also increases discoverability. 👍
Checked the types, if anything is missing etc. Only spotted that for Color its integer properties r8, g8, b8, a8 are not exposed. So that's to potentially reconsider before merging.
Overall LGTM!
AThousandShips
approved these changes
Aug 15, 2024
KoBeWi
force-pushed
the
subproperty_of_a_subproperty_of_a_property
branch
from
f42055f to
0dea6ef
Compare
akien-mga
approved these changes
Aug 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropertySelector allows picking properties of an Object, but I sometimes missed being able to pick a sub-property, e.g.
position:x. They had to be specified manually, which is rather cumbersome.This PR enhances the PropertySelector to recursively display sub-properties:
rmnhM7IxJi.mp4
It's more relevant now that the selector is exposed to scripting.