Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcpak to 2.0 #95557

Closed
wants to merge 1 commit into from
Closed

Conversation

BlueCube3310
Copy link
Contributor

Depends on #89567

Updates etcpak to 2.0, the latest official version. Said version also includes bc7enc as a dependency (though not used by Godot's importer), should it be removed with a Godot-specific patch?

@fire
Copy link
Member

fire commented Aug 15, 2024

It makes sense to add a readme addition to remove bc7enc

@clayjohn
Copy link
Member

It looks like all this does is remove CompressEtc1Alpha and CompressEtc2Alpha and adds CompressBc7. But I guess it would be nice to be back on an official release.

Is there any value in us using the BC7 compression here? Or do we use a different/better library already?

@BlueCube3310
Copy link
Contributor Author

The BC7 compression is much faster than CVTT (what Godot uses currently), although the quality is generally lower (only 4 block modes are available) and most of the performance improvements require SSE4/AVX2.

@clayjohn
Copy link
Member

The BC7 compression is much faster than CVTT (what Godot uses currently), although the quality is generally lower (only 4 block modes are available) and most of the performance improvements require SSE4/AVX2.

Ah, so probably not worth integrating yet. I would do a Godot-specific patch to remove it just due to the size

@BlueCube3310
Copy link
Contributor Author

I'm closing this for now as the upstream changes aren't significant to Godot's implementation, plus now it requires a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants