Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Destroy script before clearing owner #95676

Merged
merged 1 commit into from
Aug 19, 2024
Merged

C#: Destroy script before clearing owner #95676

merged 1 commit into from
Aug 19, 2024

Conversation

raulsntos
Copy link
Member

The C# script destructor needs to access the owner (i.e.: to disconnect signals) so we now clear it after the script has been destroyed.

@raulsntos
C#: Destroy script before clearing owner
5e7fda8 
The C# script destructor needs to access the owner (i.e.: to disconnect signals) so we now clear it after the script has been destroyed.
@raulsntos raulsntos added this to the 4.4 milestone Aug 17, 2024
@raulsntos raulsntos requested a review from a team as a code owner August 17, 2024 02:11
@gturri
Copy link
Contributor

gturri commented Aug 17, 2024

Great!
I confirm that this fixes the issue I reported in #95663 .
Thanks!

paulloz
paulloz approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit 1ac1d03 into godotengine:master Aug 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/clear-owner-order branch August 19, 2024 11:39
@jss2a98aj jss2a98aj mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulloz paulloz paulloz approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

C# code leads to crashing the game (instead of just logging an error)
4 participants
@raulsntos @gturri @akien-mga @paulloz