Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation to clarify un-interpolatable type on animation blending #95722

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Add documentation to clarify un-interpolatable type on animation blending #95722

merged 1 commit into from
Sep 2, 2024

Conversation

TokageItLab
Copy link
Member

Clarify that interpolation is not possible for the following variant types and that other values can be interpolated by animation.

  • Nil
  • NodePath
  • RID
  • Object
  • Callable
  • Signal
  • Dictionary
  • PackedByteArray

@TokageItLab TokageItLab added this to the 4.x milestone Aug 18, 2024
@TokageItLab TokageItLab requested a review from a team August 18, 2024 00:30
@TokageItLab TokageItLab requested a review from a team as a code owner August 18, 2024 00:30
@TokageItLab TokageItLab changed the title Add document to clearfy un-interpolatable type on animation blending Add document to clarify un-interpolatable type on animation blending Aug 18, 2024
@TokageItLab TokageItLab force-pushed the docs-for-interpolatable-type branch from c055ffc to 3e12429 Compare August 18, 2024 00:31
@TokageItLab TokageItLab modified the milestones: 4.x, 4.4 Aug 25, 2024
SaracenOne
SaracenOne approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akien-mga akien-mga changed the title Add document to clarify un-interpolatable type on animation blending Add documentation to clarify un-interpolatable type on animation blending Sep 2, 2024
@akien-mga akien-mga merged commit 0a7dfa1 into godotengine:master Sep 2, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
documentation topic:animation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@TokageItLab @akien-mga @fire @SaracenOne