Fix compilation issues caused by far identifier

[AThousandShips]

Breaks some builds on Win due to macro use of this name

Did a search and there doesn't seem to be any other cases like this, with regex of \bfar( =|;|,)

It might be possible to declare our own macro for this to enforce failing when introducing identifiers like this, will see if I can make something work (that also doesn't break things)

• Fixes: Unable to build master branch due to expected unqualified-id errors in camera_3d_gizmo_plugin.cpp on Windows llvm-mingw #95766

[AThousandShips]

@Anutrix I don't have a MinGW setup that works right now (correction, I don't have anything set up for building the editor with MinGW), can you confirm that the engine builds with this PR? See here for instructions for checking out a PR

[Anutrix]

@Anutrix I don't have a MinGW setup that works right now (correction, I don't have anything set up for building the editor with MinGW), can you confirm that the engine builds with this PR? See here for instructions for checking out a PR

@AThousandShips Yes. It works with the changes in this MR. Thx.

Also, just curious how you found out that far is a macro in Windows environments. 'far' being too short and a very common word makes it hard to find any info about it.

[alvinhochun]

far and also near are for compatibility with old code. Back in the 16-bit era there was the distinction between near pointers and far pointers, nowadays long gone, but of course MS still has them in the Windows headers. Which mingw-w64 headers follow suit.

I don't understand why the MSVC CI build doesn't catch this though. Shouldn't it be causing the same issue there?

[akien-mga]

Thanks!

[AThousandShips]

Thank you!