Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AudioStreamPlaybackInteractive::get_current_clip_index(). #95839

Merged

Conversation

GustJc
Copy link
Contributor

@GustJc GustJc commented Aug 20, 2024

Closes godotengine/godot-proposals#10494

Add a way to get what is the currently playing clip from AudioStreamPlaybackInteractive.
Exposes get_current_clip_index()

@akien-mga akien-mga added this to the 4.x milestone Aug 20, 2024
@akien-mga akien-mga requested review from a team August 20, 2024 06:57
@GustJc GustJc force-pushed the interactive_audio_current_playback branch from 4950d1a to ed102a8 Compare August 20, 2024 10:19
@AThousandShips AThousandShips changed the title Exposes interactive audio playback current playing clip. Expose AudioStreamPlaybackInteractive::get_current_clip_index(). Aug 20, 2024
@GustJc GustJc force-pushed the interactive_audio_current_playback branch from ed102a8 to f1c5d8c Compare September 11, 2024 03:18
@GustJc GustJc force-pushed the interactive_audio_current_playback branch from f1c5d8c to e61224e Compare December 4, 2024 04:53
@GustJc GustJc force-pushed the interactive_audio_current_playback branch from e61224e to 0675206 Compare December 6, 2024 15:32
@clayjohn
Copy link
Member

Just a head up, this is failing checks now because the added const needs to be matched in the docs.

@GustJc GustJc force-pushed the interactive_audio_current_playback branch from 0675206 to 12f682b Compare December 10, 2024 10:37
@GustJc
Copy link
Contributor Author

GustJc commented Dec 10, 2024

Just a head up, this is failing checks now because the added const needs to be matched in the docs.

Oh thanks, I didn't realize that.
It should be fixed now.

@Repiteo Repiteo merged commit ae38cdb into godotengine:master Dec 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 10, 2024

Thanks!

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Dec 10, 2024
@GustJc GustJc deleted the interactive_audio_current_playback branch December 10, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the currently playing clip in AudioStreamInteractive
7 participants