Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipper2: Update to 1.4.0 #95964

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Chubercik
Copy link
Contributor

@Chubercik Chubercik requested a review from a team as a code owner August 22, 2024 22:54
@Calinou Calinou added this to the 4.x milestone Aug 22, 2024
@Chubercik
Copy link
Contributor Author

Chubercik commented Aug 23, 2024

Uh-oh: llvm/llvm-project#16778

Edit: fixed by opting out of 128bit arithmetic (see patches)

Edit 2: more specifically, the issue is as follows:

  1. Compiler-RT implements functions that libgcc doesn’t (ex. __muloti4).
  2. LLVM lowers 128-bit arithmetic to calls to that builtin, because the target (AArch64) said it supports.
  3. The linker fails to find the symbol because the actual runtime (libgcc) doesn’t.

See: [Proposal] split built-ins from the rest of “compiler-rt”

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, if it works :D

Needs rebase to remove the merge commit.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Nov 26, 2024
@Chubercik
Copy link
Contributor Author

Rebased :)

@Repiteo Repiteo merged commit 1606b18 into godotengine:master Nov 26, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 26, 2024

Thanks!

@Chubercik Chubercik deleted the clipper2-1.4.0 branch November 26, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants