Fix LineEdit word mode when there are no more words #96038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LineEdit did not properly handle word mode (holding control) while moving the caret or using backspace or delete and there were no more words, only symbols.
Try it on only symbols like
{}or mixed words and symbols like{test}.You won't be able to move the caret to the start or end of the text, and backspace/delete won't remove to the start/end of the text when holding control.
Also fixed TextEdit since it had this same problem with delete if there were no words.
Added tests for TextEdit. I could start a new test file for LineEdit if we want.
Updated the comments for each of them for consistency and accuracy, since its not about glyphs.