Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RenderingServer.canvas_item_attach_skeleton #96056

Merged

Conversation

Lielay9
Copy link
Contributor

@Lielay9 Lielay9 commented Aug 25, 2024

Exposes the function 'RenderingServer.canvas_item_attach_skeleton'. The function is used internally by Polygon2D. Exposing it allows bypassing the Polygon2D and creating 2D-meshes that use skeletons directly (which I need for a custom importer of 2D meshes/skeletons that have blend-shapes; not supported by polygons). Did some basic testing and seems to work without issue, but second eyes would be welcome: e.g. is there a reason the function wasn't exposed?

@Lielay9 Lielay9 requested review from a team as code owners August 25, 2024 01:43
@Lielay9 Lielay9 changed the title Expose the function 'RenderingServer.canvas_item_attach_skeleton' Expose RenderingServer.canvas_item_attach_skeleton Aug 25, 2024
@Calinou Calinou added this to the 4.x milestone Aug 25, 2024
@clayjohn clayjohn modified the milestones: 4.x, 4.4 Aug 31, 2024
@akien-mga akien-mga merged commit 28b2ed5 into godotengine:master Sep 2, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Lielay9 Lielay9 deleted the expose_canvas_item_attach_skeleton branch September 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants