-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add navigation region point and segment queries #96092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97d0279
to
5fc1ea5
Compare
Scony
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always I recommend adding few test cases to cover new functions :)
5fc1ea5
to
947e8c2
Compare
Scony
approved these changes
Sep 9, 2024
Adds point and segment queries for regions, e.g. closet point, point normal, or segment intersection.
947e8c2
to
287fdb1
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds point and segment queries for regions, e.g. closet point, point normal, or segment intersection.
Also updates the function documentation for the related map queries.
This gets added because quite frequently users voiced the need to do more local queries just on a single region instead of an entire navigation map.
Something to consider, a noticeable amount of this demand came from users that replaced their Geometry2D or physics queries with navigation queries as the API works better for their project needs. E.g. the Geometry2D class is unfriendly to query more complex polygons and physics has its own set of query limitations.