Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigation region point and segment queries #96092

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Aug 25, 2024

Adds point and segment queries for regions, e.g. closet point, point normal, or segment intersection.

Also updates the function documentation for the related map queries.

This gets added because quite frequently users voiced the need to do more local queries just on a single region instead of an entire navigation map.

Something to consider, a noticeable amount of this demand came from users that replaced their Geometry2D or physics queries with navigation queries as the API works better for their project needs. E.g. the Geometry2D class is unfriendly to query more complex polygons and physics has its own set of query limitations.

@smix8 smix8 added this to the 4.4 milestone Aug 25, 2024
@smix8 smix8 requested review from a team as code owners August 25, 2024 23:34
@smix8 smix8 requested review from a team and removed request for a team August 25, 2024 23:34
@smix8 smix8 force-pushed the region_point_query branch from 97d0279 to 5fc1ea5 Compare August 25, 2024 23:50
Copy link
Contributor

@Scony Scony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always I recommend adding few test cases to cover new functions :)

Adds point and segment queries for regions, e.g. closet point, point normal, or segment intersection.
@smix8 smix8 force-pushed the region_point_query branch from 947e8c2 to 287fdb1 Compare September 9, 2024 23:40
@akien-mga akien-mga merged commit 5303688 into godotengine:master Sep 10, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the region_point_query branch September 13, 2024 14:15
@smix8 smix8 mentioned this pull request Dec 24, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants