[Doc] Clarify ProjectSettings hdr_2d description
#96096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
documentation
cherrypick:4.3
Calinou
reviewed
Aug 26, 2024
Wierdox
force-pushed
the
doc_clarify_hdr_2d_description
branch
from
ab4daad to
68799be
Compare
clayjohn
approved these changes
Sep 3, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original
ProjectSettings.hdr_2ddescription doesn't explain the ramifications of enabling it, so I copied over most of theViewport.use_hrd_2ddescription.I decided to omit the text "
(if the Viewport is attached to the screen)" directly after it says "will be converted to sRGB space immediately before blitting to the screen", since it should always be active as the root viewport, but maybe I'm wrong and it should go back.