Fix incorrect parameters for layered textures in VRAM texture memory profiler #96128
+39
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCube3310
force-pushed
the
vram-profiler-texture-mem
branch
from
89edd94 to
2e3beaf
Compare
BlueCube3310
force-pushed
the
vram-profiler-texture-mem
branch
3 times, most recently
from
acd1f02 to
1664e49
Compare
clayjohn
reviewed
Sep 1, 2024
BlueCube3310
force-pushed
the
vram-profiler-texture-mem
branch
from
1664e49 to
eccdc5a
Compare
BlueCube3310
force-pushed
the
vram-profiler-texture-mem
branch
from
eccdc5a to
e74bc30
Compare
clayjohn
approved these changes
Sep 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The texture memory profiler used to incorrectly assume the texture's depth to also be its layer count, which caused invalid memory size estimations. Additionally, RD-based renderers would always assume a texture had mipmaps due to incorrect logic for checking their count.
Before:
After:
