GLTF: Only create MeshInstance3D when needed #96133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Aug 26, 2024
AThousandShips
approved these changes
Aug 27, 2024
modules/gltf/extensions/gltf_document_extension_convert_importer_mesh.cpp
Outdated
Show resolved
Hide resolved
aaronfranke
force-pushed
the
gltf-imp-mesh-inst-create
branch
from
67dc22d to
263f089
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fire pointed out this suboptimal code to me. Right now the code creates a MeshInstance3D, then checks if a mesh is available, and if not it deletes it. This is silly, there's no need to create and then delete when we can instead just move the creation inside of the if statement.
We expect that if an ImporterMeshInstance3D does not have a valid mesh, that the ImporterMeshInstance3D should not have been created in the first place, and there is a problem at some earlier stage of the import process. So I added a warning in the place that there used to be a memdelete.
Also, I renamed the
ImporterMeshInstance3D *mesh_3dlocal variable toimporter_mesh_3dfor clarity.