Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collapsing TreeItem not updating horizontal scrollbar #96142

Merged

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Aug 27, 2024

When the column parameter of Tree::item_changed() is -1, it means that all columns are changed.

To test: Add a node hierarchy to the Scene tree in the editor, then rename a child node to a very long name so that a horizontal scrollbar appears. Try toggling the collapsing state of the root node.

@timothyqiu timothyqiu added bug topic:gui cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 27, 2024
@timothyqiu timothyqiu added this to the 4.4 milestone Aug 27, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner August 27, 2024 03:59
@akien-mga akien-mga merged commit 68a04bb into godotengine:master Sep 2, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the one-signal-to-invalidate-them-all branch September 2, 2024 16:32
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants