Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thorvg: Update to 0.14.7 #96167

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

akien-mga
Copy link
Member

Fixes #95861.

@akien-mga akien-mga added bug topic:buildsystem topic:thirdparty cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 27, 2024
@akien-mga akien-mga added this to the 4.4 milestone Aug 27, 2024
@akien-mga akien-mga requested a review from a team as a code owner August 27, 2024 13:54
@akien-mga akien-mga merged commit fe02444 into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga akien-mga deleted the thorvg-0.14.7 branch August 27, 2024 21:09
@mikemaas
Copy link

Can confirm this fix works with the latest VS preview. I hit the issue but can now successfully compile and link.

  • Windows 11 (10.0.22631 Build 22631)
  • Visual Studio 17.12.0 Preview 1.0
  • SCons v4.8.0

Thank you.

@aaronfranke
Copy link
Member

This caused a regression: #96262

@akien-mga
Copy link
Member Author

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
0x0ACB pushed a commit to gw2cc/godot that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to build on windows using MSVC 14.42 due to ThorVG
3 participants