Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing USER prefix from script-logged errors #96168

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

CreatedBySeb
Copy link
Contributor

Removes the USER prefix prepended by certain logging functions when pushing an error manually from scripts, as per discussion in #96086. This prefix was only present in some places, and could be confusing as to the actual source of the error.

Fixes #96086

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga added this to the 4.4 milestone Aug 27, 2024
@CreatedBySeb CreatedBySeb marked this pull request as ready for review August 27, 2024 14:44
@CreatedBySeb CreatedBySeb requested review from a team as code owners August 27, 2024 14:44
@RedMser
Copy link
Contributor

RedMser commented Aug 27, 2024

From what I can tell, this makes the p_editor_notify parameter unused for these places.
I don't know if it should be removed, since I'm not sure what information it exactly conveys, but just pointing out that it could be removed, if it is not deemed useful anymore.

@akien-mga
Copy link
Member

akien-mga commented Aug 27, 2024

From what I can tell, this makes the p_editor_notify parameter unused for these places. I don't know if it should be removed, since I'm not sure what information it exactly conveys, but just pointing out that it could be removed, if it is not deemed useful anymore.

See #96086 (comment).

That's a minor annoyance of deeply nested OO stuff :)

(If you have an idea for how to refactor all this code to avoid passing around a bool in 35 files that's used only once, that's worth doing though.)

@akien-mga akien-mga merged commit 431c583 into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading "USER ERROR:" prefix in logs when using Push Error
3 participants