Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix unreachable code #96173

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Aug 27, 2024

Fixes a regression introduced by #94511 which made a section of unreachable code, causing build failure on MSVC w/ warnings-as-errors + extra warnings enabled

@Repiteo Repiteo added this to the 4.4 milestone Aug 27, 2024
@Repiteo Repiteo requested a review from a team as a code owner August 27, 2024 15:32
@Repiteo Repiteo added regression and removed bug labels Aug 27, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it! Thank you godot-prs-by-file for saving me opening a duplicate PR

@akien-mga akien-mga merged commit 142d332 into godotengine:master Aug 27, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 27, 2024
@Repiteo Repiteo deleted the core/fix-unreachable-code branch August 27, 2024 16:09
@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants