-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weird plural of public method names of EditorDebuggerNode
#96176
Fix weird plural of public method names of EditorDebuggerNode
#96176
Conversation
I'm sure @AThousandShips will have a good laugh. |
EditorDebuggerNode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure these need compat methods necessarily, while they are exposed to modules I don't know that we guarantee any compatibility with those and these are only used internally
Otherwise this looks good
Yeah the compat methods are not needed, they're only relevant (or even, useful) for methods bound to the scripting API via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How
English is hard tbh, it's no french but English spelling is weird |
78fd479
to
dfe7ef7
Compare
Removed the compatibility methods! |
Thanks! |
I changeds the public method names of:
EditorDebuggerNode::_method_changeds
, andEditorDebuggerNode::_property_changeds
to something more relevant:
EditorDebuggerNode::_methods_changed
, andEditorDebuggerNode::_properties_changed