Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird plural of public method names of EditorDebuggerNode #96176

Merged

Conversation

adamscott
Copy link
Member

I changeds the public method names of:

  • EditorDebuggerNode::_method_changeds, and
  • EditorDebuggerNode::_property_changeds

to something more relevant:

  • EditorDebuggerNode::_methods_changed, and
  • EditorDebuggerNode::_properties_changed

@adamscott
Copy link
Member Author

I'm sure @AThousandShips will have a good laugh.

@adamscott adamscott changed the title Fix weird plural public method names Fix weird plural of public method names of EditorDebuggerNode Aug 27, 2024
@adamscott adamscott added this to the 4.x milestone Aug 27, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure these need compat methods necessarily, while they are exposed to modules I don't know that we guarantee any compatibility with those and these are only used internally

Otherwise this looks good

@akien-mga
Copy link
Member

Yeah the compat methods are not needed, they're only relevant (or even, useful) for methods bound to the scripting API via bind_methods. We don't keep deprecated methods only for modules' sake, as binary compatibility isn't a question (the whole engine needs to be compiled), so the module code can be adjusted.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 27, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How

@AThousandShips
Copy link
Member

English is hard tbh, it's no french but English spelling is weird

@adamscott adamscott force-pushed the fix-wrong-plural-method-debugger branch from 78fd479 to dfe7ef7 Compare August 27, 2024 17:37
@adamscott
Copy link
Member Author

Removed the compatibility methods!

@akien-mga akien-mga merged commit a2f097d into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants