Improve error message when loading non-PNG splash image #96197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Aug 28, 2024
jsjtxietian
force-pushed
the
splash-msg
branch
from
74ac97f to
c7a0e39
Compare
timothyqiu
approved these changes
Aug 29, 2024
akien-mga
changed the title
|
Thanks! |
kleonc
reviewed
Aug 29, 2024
| @@ -3307,7 +3307,8 @@ void Main::setup_boot_logo() { | |||
| boot_logo.instantiate(); | |||
| Error load_err = ImageLoader::load_image(boot_logo_path, boot_logo); | |||
| if (load_err) { | |||
| ERR_PRINT("Non-existing or invalid boot splash at '" + boot_logo_path + "'. Loading default splash."); | |||
| String msg = (boot_logo_path.ends_with(".png") ? "" : "The only supported format is PNG."); | |||
| ERR_PRINT("Non-existing or invalid boot splash at '" + boot_logo_path + +"'. " + msg + " Loading default splash."); | |||
There was a problem hiding this comment.
That's a potential double space here. 🙃 One of the spaces should be a part of msg.
There was a problem hiding this comment.
And I noticed the double + too, lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96177
Are there any other places that needs check?