Fix crash when selecting ownerless 3D node. #96199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
added
bug
topic:editor
crash
topic:3d
cherrypick:4.3
fire
reviewed
Aug 28, 2024
|
It can, but it can also refer to nodes that instanced which don't actually appear in the scene tree, like in the example, nodes instanced by tools which don't appear in the inspector and aren't serialized. The specific issue here I believe is that the code which is meant to select the parents of ownerless nodes didn't account for ownerless nodes which are direct descendents of the edited scene root. |
akien-mga
approved these changes
Aug 28, 2024
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96116
Apologies for this oversight and thanks to @CreatedBySeb for providing a fix.