Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Make file filters case insensitive. #96204

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 28, 2024

While file system might be case-sensitive, file extension filters usually an't expected to be.

@bruvzg bruvzg added this to the 4.x milestone Aug 28, 2024
@fire fire requested a review from a team August 28, 2024 23:07
@bruvzg bruvzg marked this pull request as ready for review August 29, 2024 17:41
@bruvzg bruvzg requested a review from a team as a code owner August 29, 2024 17:41
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 29, 2024
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious how this handles the infamous turkish i.

@bruvzg
Copy link
Member Author

bruvzg commented Aug 29, 2024

I'm curious how this handles the infamous turkish i.

It's not in the case mapping so won't be converted, but it's probably irrelevant to this use case, I have never seen file extensions that aren't basic Latin.

@akien-mga akien-mga merged commit 0897d83 into godotengine:master Aug 30, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants