Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Suppress unnecessary ar messages #96220

Closed
wants to merge 1 commit into from
Closed

[Windows] Suppress unnecessary ar messages #96220

wants to merge 1 commit into from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 28, 2024

Removes some useless creating ***.a waning messages cause by #94747, which enabled stderr print, and ar is sending these to stderr without c modifier.

@bruvzg bruvzg added this to the 4.4 milestone Aug 28, 2024
@bruvzg bruvzg requested a review from a team as a code owner August 28, 2024 12:02
@akien-mga
Copy link
Member

CC @alvinhochun

@alvinhochun
Copy link
Contributor

Looks fine to me, thanks.

@alvinhochun alvinhochun mentioned this pull request Aug 31, 2024
Merged
@akien-mga
Copy link
Member

Superseded by #96407.

@akien-mga akien-mga closed this Sep 6, 2024
@akien-mga akien-mga removed this from the 4.4 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived enhancement platform:windows topic:buildsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @alvinhochun