Account for dropcap when calculating paragraph size, fix duplicate last char when using dropcap with autowrap off. #96265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st char when using dropcap with autowrap off.
Does this also fix #94819? As in, fixing the duplicate last char when autowrap is set to any value other than off |
Yes, should fix it as well. |
akien-mga
approved these changes
Sep 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96255
Fixes #94819
Note: dropcap is still not convenient to use with autowrap off, since only one paragraph will flow around it (and a normal new line will start a new paragraph), but you can force breaks within a paragraph with other line breaking characters, e.g,
[char=0B].