Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests for String insert and join. #96291

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add more unit tests for String insert and join. #96291

merged 1 commit into from
Aug 30, 2024

Conversation

miv391
Copy link
Contributor

@miv391 miv391 commented Aug 29, 2024 •
edited
Loading

Added more unit tests for recently optimized String::insert and String::join (#92555, #92550).

@miv391 miv391 requested a review from a team as a code owner August 29, 2024 17:10
@AThousandShips AThousandShips changed the title Added more unit tests for String insert and join. Add more unit tests for String insert and join. Aug 29, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Aug 29, 2024
fire
fire approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look reasonable and they pass cicd.

@akien-mga akien-mga changed the title Add more unit tests for String insert and join. Add more unit tests for String insert and join. Aug 30, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 30, 2024
@akien-mga akien-mga merged commit ce069e4 into godotengine:master Aug 30, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@miv391 miv391 deleted the string-unit-tests branch December 31, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:core topic:tests
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@miv391 @akien-mga @fire @AThousandShips