Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thorvg: Update to 0.14.8, and backport upstream fix for Bezier precision regression #96320

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Aug 30, 2024

Fixes #96262 by backporting thorvg/thorvg#2702.

Edit: Changed to use the upstream fix instead of a temporary revert.

@akien-mga akien-mga added bug topic:thirdparty regression cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 30, 2024
@akien-mga akien-mga added this to the 4.4 milestone Aug 30, 2024
@akien-mga akien-mga requested a review from a team as a code owner August 30, 2024 08:39
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixes the problem, but may be better to wait a few hours or days before merging in case upstream has a better fix for us.

@akien-mga akien-mga changed the title thorvg: Update to 0.14.8, and workaround Bezier precision regression thorvg: Update to 0.14.8, and backport upstream fix for Bezier precision regression Sep 2, 2024
@akien-mga akien-mga merged commit 19b893d into godotengine:master Sep 2, 2024
19 checks passed
@akien-mga akien-mga deleted the thorvg-0.14.8 branch September 2, 2024 10:30
@akien-mga
Copy link
Member Author

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG does not render correctly in master as of PR #96167 (works in 4.3 stable)
3 participants