Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dropping code in script editor #96371

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Improve dropping code in script editor #96371

merged 1 commit into from
Sep 3, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 31, 2024

  • adds type variable instead of checking for "type" every time
  • changes files type to PackedStringArray (the original type of "files")
  • uses PackedStringArray to join strings

@KoBeWi KoBeWi added this to the 4.x milestone Aug 31, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner August 31, 2024 09:39
@Mickeon
Copy link
Contributor

Mickeon commented Sep 2, 2024

It looks like after the clean-up that whole section of code could be rewritten as a switch-case block

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 2, 2024

You can't switch-case a string.

Mickeon
Mickeon approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional change, it's just much cleaner code.

@Mickeon Mickeon modified the milestones: 4.x, 4.4 Sep 3, 2024
@akien-mga akien-mga merged commit d0a7dcd into godotengine:master Sep 3, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the mentos branch September 3, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @Mickeon @akien-mga