mingw: Only use ar --thin on supported versions
#96373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinhochun
force-pushed
the
mingw-ar-thin-flag
branch
from
91a202b to
fd8c6c9
Compare
The flag is supported since Binutils 2.38 [1] or LLVM 14 [2]. [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=28759 [2]: llvm/llvm-project@dd6e7e0
alvinhochun
force-pushed
the
mingw-ar-thin-flag
branch
from
fd8c6c9 to
35a8ff9
Compare
bruvzg
approved these changes
Sep 2, 2024
akien-mga
approved these changes
Sep 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is supported since Binutils 2.38 1 or LLVM 14 2.
llvm-ar.exe: error: unknown option -when using llvm (llvm-mingw) prior to v14 #96336It seems I misunderstood when making the original PR -
--thinwas added to Binutils only in 2.38 also in 2022. Added version checks for both Binutils and LLVM.