GDExtension: Show warning on missing PDB file, rather than error #96383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
platform:windows
topic:gdextension
cherrypick:4.3
|
I just tested this and can confirm that it works as intended. |
|
@mihe Thanks! Taking out of draft based on mihe's testing :-) |
mihe
approved these changes
Aug 31, 2024
dsnopek
force-pushed
the
gdextension-pdb-missing-error
branch
from
d247d65 to
760099c
Compare
Hilderin
approved these changes
Aug 31, 2024
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96350
Marking as a draft for now, because I haven't had a chance to test it yet (since Windows isn't my main development platform).