-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Merge duplicate entries in enum property inspector #96386
[Editor] Merge duplicate entries in enum property inspector #96386
Conversation
Disabling duplicated enumerators feels wrong to me because the underneath value is, in fact, usable. Having to use a different name defeats the purpose of giving the value an alternate name in the first place. Maybe it's better to show duplicated enumerators as one entry. For example, for this enum enum TestEnum2 { TEST = 1, TEST2 = 0, TEST3 = 1 } show these two options:
|
Can try that, bit more convoluted code, but unsure if it's not more confusing, the underlying issue here is that people get confused when clicking But will test that, it'll be a bunch of additional code but should be easy |
Pushed an alternative solution, however not sure how enum keys work with RTL languages in the interface so it might be weird with RTL languages being used, but someone knowledgeable in that can probably answer that |
Localization of enum dropdowns in the inspector is currently disabled. We have not implemented string extraction for hint strings in editor codebase yet. For user-defined texts like this, I think it's better to leave them untranslated. |
Was more like how But I think that's probably a future problem to evaluate for the editor interface and not critical here |
43f2cb7
to
bcf4c6f
Compare
This helps with confusion over how selecting a key with a duplicate value won't be selected as only the first entry with a particular value will be selected.
bcf4c6f
to
7d8684f
Compare
Thanks! |
Thank you! |
This helps with confusion over how selecting a key with a duplicate value won't be selected as only the first entry with a particular value will be selected.
See: