Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Path2D editor not updating gizmos on selection in scene tree #96404

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

larspet
Copy link
Contributor

@larspet larspet commented Aug 31, 2024

Fixes #96392

You still need to release LMB before it updates, but the same goes for other editors, like the Polygon2D editor.

Is there even a reason for _handles and _edit to be called on mouse up after clicking a tree node, instead of on mouse down?
When selecting multiple nodes by holding CTRL, each additional node will be selected (and inspector updated etc.) on mouse down, but this is not the case for single selections.

Edit: Right, I just remembered that the delayed mouse up selection is needed for dragging nodes into the inspector.

@larspet larspet requested a review from a team as a code owner August 31, 2024 19:55
@AThousandShips AThousandShips added this to the 4.4 milestone Sep 1, 2024
@akien-mga akien-mga merged commit 55ab2f7 into godotengine:master Sep 16, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@larspet larspet deleted the path2d-selection branch December 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path2D Curve point edit gizmos are not updated immediately on node selection, only on mouse hover
5 participants