Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this indeed fixes #96354, I still have no idea what was a root cause of this issue in a first place.
There is this part in
SceneReplicationInterface::_send_sync
:Reason why in my project I was getting these divisions by zero was because this line always returned no props, and yet code underneath it kept executing. It gets a resulting size of 0, submits it to the profiler and this crash would occur.
Even with this fix it feels like there is an overarching issue, since now object is still somehow synced, but the reported size is always reported as zero, even if it is actually being replicated from time to time.