Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic6DOFJoint3D: Rename FLAG_ENABLE_MOTOR to FLAG_ENABLE_ANGULAR_MOTOR #96458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaronfranke
Copy link
Member

Minor rename that preserves backwards compatibility. It was driving me nuts (pun intended) that linear motors were called "linear motor" but angular motors were called just "motor". This PR adds "angular motor" to make this less confusing.

Note: I did not do the rename in HingeJoint3D because there's only one motor for that joint type.

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do approve, but I am not sure if it's my place to speak. Say for example, this inconsistency may have been done to be consistent with another part of the API, instead.

@aaronfranke aaronfranke modified the milestones: 4.4, 4.x Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants